fix Issue 14940: Can't call logger with more complex objects #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
quickfur
changed the title
| @@ -1799,8 +1799,7 @@ Params: | |||
| _isNull = false; | |||
| } | |||
|
|
|||
| template toString() | |||
| { | |||
| template toString() { | |||
There was a problem hiding this comment.
Nitpick: opening brace on own line, please.
|
@quickfur @Hackerpilot done |
|
While this fixes the specific issue, isn't the deeper problem that |
|
@mathias-baumann-sociomantic not really the OutputRange delegate passed to Nullable is not @safe and as this delegate is called by toString it can not be @safe |
|
Code duplication looks a bit worrying here. Can't dmd infer attributes for delegate here? (considering |
|
@mihails-strasuns-sociomantic no it didn't making the delegate a template parameter also didn't work. The alias this was then used instead of the toString |
|
Auto-merge toggled on |
|
Puttin aside the general problem with delegates, merging this |
DmitryOlshansky
added a commit
that referenced
this pull request
Sep 2, 2015
fix Issue 14940: Can't call logger with more complex objects
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14940