[REG] fix Issue 14861 - Error in stdio.d in LockingTextReader.readFront() #3698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| while(!fr.eof) | ||
| fr.readf("%s;%s;%s;%s\n", &nom, &fam, &nam, &ot); | ||
| fr.close(); | ||
| std.file.remove(deleteme); |
There was a problem hiding this comment.
should be in scope(exit) right after creation
WalterBright
force-pushed
the
fix14861
branch
from
b32450a to
196f251
Compare
|
This is a regression fix. It needs pulling. |
WalterBright
changed the title
Open against the stable branch then? All in all it looks good. |
|
Auto-merge toggled on |
DmitryOlshansky
added a commit
that referenced
this pull request
Nov 13, 2015
[REG] fix Issue 14861 - Error in stdio.d in LockingTextReader.readFront()
tramker
pushed a commit
to tramker/phobos
that referenced
this pull request
Jan 27, 2016
[REG] fix Issue 14861 - Error in stdio.d in LockingTextReader.readFront() Conflicts: std/stdio.d Signed-off-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the decoding misfeature of LockingTextReader. Also, the call to ungetc() is moved to the destructor, so it only gets called once.
https://issues.dlang.org/show_bug.cgi?id=14861
The earlier attempt:
#3622
Alternate fix proposal:
#3696