Skip to content

Conversation

9il
Copy link
Member

@9il 9il commented Oct 11, 2015

deallocate cause memory leaks
https://issues.dlang.org/show_bug.cgi?id=15188

@@ -962,8 +962,8 @@ struct SharedFreeList(ParentAllocator,
incNodes();
return true;
}
static if (is(typeof(parent.deallocate(block))))
return parent.deallocate(block);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block is undefined

@9il
Copy link
Member Author

9il commented Oct 14, 2015

@MartinNowak This PR is very simple too. block variable is undefined. So b should be used, plus traits style was unified with other code in the module.

@Hackerpilot
Copy link
Contributor

@DmitryOlshansky
Copy link
Member

LGTM - rebase to kick the tester

@Hackerpilot Hackerpilot added this to the 2.069.0 milestone Oct 15, 2015
@9il
Copy link
Member Author

9il commented Oct 15, 2015

Rebased

@Hackerpilot
Copy link
Contributor

Auto-merge toggled on

Hackerpilot added a commit that referenced this pull request Oct 15, 2015
[DMD 2.069][allocators] Fix issue 15188
@Hackerpilot Hackerpilot merged commit cfca3d6 into dlang:master Oct 15, 2015
@9il 9il deleted the patch-4 branch October 15, 2015 23:38
@MartinNowak
Copy link
Member

Can you guys please open those against the stable branch?

Hackerpilot added a commit that referenced this pull request Oct 15, 2015
[DMD 2.069][allocators] Fix issue 15188
@9il 9il restored the patch-4 branch October 15, 2015 23:59
@9il 9il deleted the patch-4 branch October 16, 2015 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants