Issue 6255 - Add support for different base conversions in std.conv #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| T toImpl(T, S)(S value) | ||
| T toImpl(T, S, Options...)(S value, Options opts) | ||
| if (isDynamicArray!S && isSomeString!S && | ||
| !isSomeString!T && is(typeof({ ElementEncodingType!S[] v = value; parse!T(v); }))) |
There was a problem hiding this comment.
Shouldn't the template constraint have something for Options? As it stands, I believe that if the wrong thing were passed to opts, the error would end up at the call site to parse within this function rather than at the call site of this function.
There was a problem hiding this comment.
Ok, my change was too hacky.
Explicit parameter uint radix is much better than implicit limited parameter opts.
|
Updated, and removed some conversions marked as unnecessary by the "removing top const" feature, |
jmdavis
added a commit
that referenced
this pull request
Jan 26, 2012
Issue 6255 - Add support for different base conversions in std.conv
|
Merged. |
marler8997
pushed a commit
to marler8997/phobos
that referenced
this pull request
Nov 10, 2019
Add a sponsorship button merged-on-behalf-of: Vladimir Panteleev <CyberShadow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://d.puremagic.com/issues/show_bug.cgi?id=6255
Now Phobos has following conversion functions:
but doesn't have