Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2011

andralex added a commit that referenced this pull request Feb 5, 2012
@andralex andralex merged commit e859e40 into dlang:master Feb 5, 2012
@DmitryOlshansky
Copy link
Member

Looks like I missed a lot, real life has it's downsides :(
After unfortunate illness intermixed with university affairs I've been off for a couple of months. As such I wasn't tuned on bugzila/groups etc. at the time. Fortunately I noticed the paths in the merge notification, issue 7141 isn't exactly descriptive.

The fix puzzles me a bit, it pinpoints the root of the problem but I'd rather do it in less intrusive way.Adding 2 extra states for parser is an overkill, as it was already a messy place.
The problem with this commit is that I think it sides-steps some range magic e.g. this test now fails:
unittest{
string pattern2 = [&-z];
bool m = !match("b",pattern2).empty;
assert(m);
}
It's late here, I'm following on this one tomorrow.

@andralex
Copy link
Member

andralex commented Feb 5, 2012

I figured you'd be busy with studies, sorry to hear you've been sick too. Great to hear your'e better, and Happy New Year.

Feel free to implement a simpler fix in a future pull request. More importantly, it would be great to discuss starting on the EBNF parser we discussed a while ago. That's a very exciting and high-profile project!

@andralex
Copy link
Member

andralex commented Feb 5, 2012

Oh, and GSOC 2012 is upon us. We need to work on applications.

WalterBright added a commit that referenced this pull request Feb 10, 2012
marler8997 pushed a commit to marler8997/phobos that referenced this pull request Nov 10, 2019
update mailmap for the author of this PR
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
marler8997 pushed a commit to marler8997/phobos that referenced this pull request Nov 10, 2019
update mailmap for the author of this PR
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants