Remove static assert(__traits(compiles, xyz)) from std.conv
#3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4398,7 +4402,7 @@ unittest | |||
| @disable this(this); | |||
| } | |||
| S1 s1 = void; | |||
| static assert( __traits(compiles, emplace(&s1, 1))); | |||
| emplace(&s1, 1); | |||
|
Other than that LGTM |
| @@ -4694,7 +4698,7 @@ unittest | |||
| } | |||
| S1 s = void; | |||
| static assert(!__traits(compiles, emplace(&s, 1))); | |||
| static assert( __traits(compiles, emplace(&s, &i))); //(works, but deprected) | |||
| static assert( __traits(compiles, emplace(&s, &i))); //(works, but deprecated) | |||
There was a problem hiding this comment.
Are these used to quell the deprecation message?
There was a problem hiding this comment.
Correct. If I call it outright the deprecation message shows up.
|
@burner fixed, and the autotester failure was transitory - thx for the review! |
Merged
|
mmmmmm pass pliz pliz pullllllllllllllllllll |
|
LGTM. Squash and auto-merge? Note that one of these commits snuck its way into your emplace PR, so you should rebase that on master after this is merged. |
WalterBright
added a commit
that referenced
this pull request
Nov 12, 2015
…mful Remove `static assert(__traits(compiles, xyz))` from `std.conv`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern
static assert(__traits(compiles, xyz))arised probably as a converse to its negation, e.g.:However, the pattern should be avoided for two reasons:
static assert(__compiles)does not show the reason in the error messages. This makes code more difficult to work with gratuitously.This is just the beginning - could someone please eliminate this pattern from all of Phobos? Thanks!