[Issue 15305] bitfields! setter erroneously clears subsequent fields

[lionello]

@property void alice(bool v) @safe pure nothrow @nogc { if (v) _alice_bob |= 1U;else _alice_bob &= ~1U;}

This getter is wrong because the &=~1U would clear not just the first bit, but bits 32-64 as well. This in turn because of the code in myToString, which picks the smallest type suffix, U in this case.

Fixed by casting the 1U to the type of the storage, before negating.

[dlang-bot]

Fix	Bugzilla	Description
✗	15305	std.manip.bitfields generate bogous code

[andralex]

Thanks!

[dnadlinger]

@lionello: If you include "fix" in the commit subject, the issue will get closed on Bugzilla automatically (and the dlang-bot report will have a check mark instead of an X).

[lionello]

@klickverbot Cool, I did not know that. Thanks!