Fix issue 12987 - topN should return the top portion of the range #3864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could somebody please have a look over this and see whether the tests need to be more robust? I'm not sure how all ranges would interact with these changes. |
|
Yah, that's right. Thanks! |
andralex
added a commit
that referenced
this pull request
Dec 8, 2015
Fix issue 12987 - topN should return the top portion of the range
|
There are problems with my changes in this PR, and I have updated my branch with some fixes. To get them, do we need to revert this PR and then do I need to open a new PR? Or is there an easier way? @JackStouffer: please scrutinise. :) |
|
You should open a new PR. Reverting this would take an extra PR anyway, so it might as well just be fixed. |
Infiltrator
added a commit
to Infiltrator/phobos
that referenced
this pull request
Dec 9, 2015
Bug unittests should go in their own blocks, and ranges should be .saved.
Infiltrator
added a commit
to Infiltrator/phobos
that referenced
this pull request
Dec 9, 2015
Bug unittests should go in their own blocks.
Infiltrator
added a commit
to Infiltrator/phobos
that referenced
this pull request
Dec 9, 2015
Bug unittests should go in their own blocks.
Infiltrator
added a commit
to Infiltrator/phobos
that referenced
this pull request
Dec 10, 2015
Bug unittests should go in their own blocks.
rcorre
pushed a commit
to rcorre/phobos
that referenced
this pull request
Dec 21, 2015
Bug unittests should go in their own blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.