add missing @nogc for Windows-only function #3898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue wasn't yet noticed until the 2.069.2 stable branch was merged back, b/c allocator was still missing from phobos' makefiles. |
|
Auto-merge toggled on |
MartinNowak
force-pushed
the
fix_master_allocator
branch
from
2456891 to
6d36fc1
Compare
|
How could someone miss that the tests for allocator weren't running on Windows? |
MartinNowak
added a commit
that referenced
this pull request
Jan 3, 2016
add missing @nogc for Windows-only function
|
Is there a single contributor other than Adam Ruppe who uses windows? |
Quite a few, from the core team it's Walter, Kenji, and Daniel. |
|
I think the answer to "How could someone miss that <insert some test here> aren't running on <insert some situation here>" is because the auto tester doesn't tell you tests that it doesn't run :) Anyway, problem solved for now, someone should investigate why the test fails when enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.