Remove suggestion in documentation to add an alias to uses of Flag #3947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I disagree with this change. We should really hash this out in the forum before any action is taken. |
|
LGTM |
1 similar comment
|
LGTM |
|
Alright let's hash it out in the forum first. |
|
The code should be left but without the alias. It should be clarified that |
brad-anderson
force-pushed
the
patch-15
branch
from
af3ab4e to
d4fa341
Compare
brad-anderson
force-pushed
the
patch-15
branch
from
d4fa341 to
7a38370
Compare
|
How's that? |
|
In case it's not clear, the example being deleted already existed above, just without the alias. It'd be an exact copy if it were left in but with the aliasing removed. |
|
cool thx! |
andralex
added a commit
that referenced
this pull request
Jan 22, 2016
Remove suggestion in documentation to add an alias to uses of Flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Andrei's comments. We might also consider explaining why an alias is a bad idea (I haven't quite figured it out myself).