[std.regex] Use ref-counting for Captures struct #4142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark? |
Need to create one for this I guess. |
|
rebase please |
DmitryOlshansky
force-pushed
the
regex-ref-counting
branch
from
450ff5e to
872673d
Compare
Doesn't show any difference on things I tried. This pull however unties matching from GC usage so we may have |
|
Auto-merge toggled on |
|
It seems this introduced a regression: |
|
Ping @DmitryOlshansky |
|
I'm on it |
|
Apparently it's caused by interaction with a compiler bug: issue 16699. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should improve cases where a lot of temporary captures allocated with big number of submatches.