reduce unittest runtime #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Jun 28, 2012
MartinNowak
commented
- use random sampling of codepoint sets
- save and print random seed for reproducibility
- add new unittest for ByCodepoint
- 12s => 4ms
- use random sampling of codepoint sets - save and print random seed for reproducibility - add new unittest for ByCodepoint - 12s => 4ms
|
Looks good. I was against always running this test in the first place (e.g. have it versioned out). |
|
If effectively did 397 * 1.114.112 trie lookups because it iterated through the negated sets too. I tried some simple off by one bugs but they never went unnoticed with even one pass of random sampling. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.