better support of foreach for array #683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the elements are accessed by reference.
Correcting indentation (4 spaces instead of two. Adding a few words and a period to the doc.
…ement, as empty Array s can be legitimately not isInitialized. Ranges don't need the check, as they iterate on indexes.
|
We need to improve ranges instead of using opApply for such trivial iteration patterns. Apologies that the thread didn't make this clear. Will close this now - sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion "foreach ref very broken: fails to call front(val)" here:
http://forum.dlang.org/thread/uoptrrkgfczyozxtkkvi@forum.dlang.org
This fix allows writting things like:
Array!int arr;
foreach(ref a; arr)
++a;
In the sense that:
I think the pull request is complete:
I implemented both opApply and opApplyReverse.
I implemented it both for Array.Range and Array (see: http://forum.dlang.org/thread/rxpbtrawpjzvdfuuwmwp@forum.dlang.org)
I implemented correct behavior for "break" cases.
I documented the public opApply.
I wrote a complete unit test.
I tested && unittested it.
This is my first time doing this, so please forgive me if I did something wrong :(