Skip to content

Switch std.algorithm/.range to lambda syntax (try 2) #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

brad-anderson
Copy link
Member

Restores "Switch std.algorithm/.range to lambda syntax" (pull request 707) which was prematurely applied and then reverted to fix the build.

This should not be applied until the autotester passes Test Results

I am mainly posting this even though it is expected to not pass the autotester so the dmd guys can perhaps investigate how it is breaking dmd unittests.

This reverts commit 4c4c35c which was a revert of 32eb03a.

@andralex
Copy link
Member

... waiting ...

@andralex
Copy link
Member

more waiting (warning, it's starting to bitrot)

This reverts commit 4c4c35c.

Restores "Switch std.algorithm/.range to lambda syntax" which was
prematurely applied and then reverted to fix the build.

Conflicts:
	std/algorithm.d
@brad-anderson
Copy link
Member Author

Rebased to avoid bitrot.

@andralex
Copy link
Member

andralex commented Sep 2, 2012

I'm starting to forget what steps we need to take to merge this in. Could you please write them down so we can mark progress?

@brad-anderson
Copy link
Member Author

All that needs to happen is the unittests need to pass. On most platforms it's UTFException in DMD's tests like this:

Running compilable tests
 ... runnable/testbounds.d          ()
std.utf.UTFException@../src/../../phobos/std/utf.d(981): Invalid UTF-8 sequence (at index 1)

It seems to occur in different places on each platform so my guess is some sort of memory corruption is occurring.

Phobos tests are failing on Win32 only. I get a Fatal Error: Out of memory error when I try to test locally though. I'll try to figure out what is going on there but the bizarre failing dmd tests are the the main blocker.

@andralex
Copy link
Member

tests still red, still waitin'

@andralex
Copy link
Member

ping

@brad-anderson
Copy link
Member Author

This has bitrot too much. Me or someone else can try again from scratch some other time.

@andralex
Copy link
Member

andralex commented Mar 1, 2013

ok, sorry for the wasted work

@brad-anderson
Copy link
Member Author

It's alright. It's wasn't a lot of work. Some closure bugs (but not all)
have been fixed since this was made so what was blocking this might already
be resolved.
On Feb 28, 2013 7:14 PM, "Andrei Alexandrescu" notifications@github.com
wrote:

ok, sorry for the wasted work


Reply to this email directly or view it on
GitHubhttps://github.com//pull/744#issuecomment-14269880
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants