fixed wrong headers for decompression #758
Conversation
In some archives the headers for each indivdual `ArchivMember` are incomplete. And these incomplete headers would overwrite the actual headers with `0` which results in a `ZlibException` (since `compressedSize` and `expandedSize` are `0`)
|
Should probably be applied to D1 Phobos as well. Cheers, Jakob. |
|
For D1 Branch: #759 |
|
The fix doesn't match the problem description. I expected to see if (field == 0) doSomething. Did this fix come from some other zip implementation or a best guess at the right way to handle it? Do you have a sample .zip that illustrates this behavior? Please construct a unit test that validates the before and after behavior. |
|
Example zip, every minecraft release after 1.2.5 (availabe from: http://www.mojang.com/ – the |
fixed wrong headers for decompression
|
merged, thanks |
In some archives the headers for each indivdual
ArchivMemberare incomplete.And these incomplete headers would overwrite the actual headers with
0whichresults in a
ZlibException(sincecompressedSizeandexpandedSizeare0).