-
-
Notifications
You must be signed in to change notification settings - Fork 741
September 2012 Deprecations #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -121,6 +121,9 @@ D language compiler. Also, check out the | |||
|
|||
<dl> | |||
|
|||
<dt><a href="std_ascii.html"><b>std.ascii</b></a> | |||
<dd>Functions which operate on ASCII characters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/which/that/
I'm coy about breaking more code. Shall we undocumment stuff so new code doesn't use it but old code still has access? |
The only code which is going to get broken here (unless someone is compiling with -d, which you're not normally supposed to do) is the deprecation of |
This pull request cannot be automatically merged. |
The other code that will get broken is code that hasn't been tried for a while. That code will be impossible to compile with or without -d. |
@andralex So, you intend to just keep cruft around in the library, even though it's been deprecated since February? When do we remove it then? We previously agreed that stuff would be scheduled for deprecation for a period of approximately 6 months before being deprecated and that it would be removed approximately 6 months after that. Are you suggesting that we keep them around but undocumented for another 6 months before outright removing them? Or are you thinking that we should be keeping them around indefinitely? It seems incredibly messy to me to keep stuff like this around long term, and it potentially increases maintenance costs. |
The deprecated stuff scheduled for removal in September is now undocumented and marked (in a normal comment) for removal in March 2013.
…ion. It hasn't actually be deprecated, but it's now undocumented and marked for possible deprecation in the future.
Okay. It's been rebased and changed so that the deprecated stuff is now undocumented and marked for removal in March instead of now (giving it over a year as deprecated before actual removal). The overload for d-programming-language.org pull request# 168 is related in that it removes std.ctype from the online docs (though it's now no longer removed from Phobos for the moment). |
What about std.regexP ? I thought we were about to remove it years ago. |
|
Ah, OK. |
LGTM. |
thanks |
This removes all of the deprecated items (save for those in std.string) which were scheduled to be removed in September 2012.
In addition, there is one item which this deprecates (the overload of
canFind
which takes a predicate), since it was scheduled to be deprecated in September. It's the only thing in this pull request which risks breaking code. Everything else involves removing deprecated stuff.This should cover everything (other than std.string's functions) which was scheduled to be either removed or deprecated in September.