Partial fix Issue 7648 #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n CP_ACP on Windows instead of UTF-8
| else | ||
|
|
||
| // filename intentionally contains non-ASCII (Russian) characters | ||
| return text("deleteme-детка.", baseName(file), ".", line); |
There was a problem hiding this comment.
Please fix the indentation here.
Done. I just wanted to make diff of unittest disabling commit a bit smaller. |
|
I'll trust you on this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Phobos related part of Issue 7648 - std.stdio expects file names to be encoded in CP_ACP on Windows instead of UTF-8, but as far as we use DigitalMars C runtime the issue is blocked by Issue 8643 - [snn] _wfopen and other non-standard wide-character functions fail with non-ASCII symbols.