Fix issue 1188

[denis-sh]

Fixes D1 only Issue 1188 - Command-line arguments are encoded in CP_ACP on Windows instead of UTF-8

[andralex]

tests are failing

[denis-sh]

tests are failing

This is D1 pull. Autotester tests D2 only. As you can see it tries to merge this into D-Programming-Language:master instead of D-Programming-Language:phobos-1.x and obviously fails.

[denis-sh]

Ping.

[denis-sh]

@WalterBright, what's wrong with this?

[andralex]

Could extern(Windows)be factored out and used as a scope here?

[andralex]

Could please someone with more Windows knowledge take over reviewing this diff? Thanks.

[ghost]

First things first, where are the unit tests?

[denis-sh]

To @andralex:

Could extern(Windows)be factored out and used as a scope here?

Factored out.

---

To @AndrejMitrovic:

First things first, where are the unit tests?

I have no experience in such kind of unittests. Show me such unittests, please (which build program, run it with arguments and test its output).

[denis-sh]

By the way, this pull works correct on my windows system.

[denis-sh]

Ping.

[ghost]

I have no experience in such kind of unittests. Show me such unittests, please (which build program, run it with arguments and test its output).

@denis-sh: My bad, I haven't realized this is D1, not D2.

[alexrp]

Since this is already in druntime for D2, I see no reason to not merge this.

[denis-sh]

Finally. Thanks a lot!

[WalterBright]

Doesn't work. Fails the test:

wc wc.d
lines words bytes file
Error: ↑

--- errorlevel 1

where wc.d is:

import std.file;

int main (char[][] args)
{
int w_total;
int l_total;
int c_total;

printf ("   lines   words   bytes file\n");
foreach (char[] arg; args[1 .. args.length])
{
    char[] input;
    int w_cnt, l_cnt, c_cnt;
    int inword;

    input = cast(char[])std.file.read(arg);

    foreach (char c; input)
    {
        if (c == '\n')
            ++l_cnt;
        if (c != ' ')
        {
            if (!inword)
            {
                inword = 1;
                ++w_cnt;
            }
        }
        else
            inword = 0;
        ++c_cnt;
    }
    printf ("%8lu%8lu%8lu %.*s\n", l_cnt, w_cnt, c_cnt, arg.length, arg.ptr);
    l_total += l_cnt;
    w_total += w_cnt;
    c_total += c_cnt;
}
if (args.length > 2)
{
    printf ("--------------------------------------\n%8lu%8lu%8lu total",
        l_total, w_total, c_total);
}
return 0;

}

[WalterBright]

hmm, love the bad auto-formatting of github!

[WalterBright]

reverted

[ghost]

Use ```D for syntax highlighting of D code.

Also, didn't I mention this pull needed unittests? :)

[denis-sh]

@WalterBright:

hmm, love the bad auto-formatting of github!

Disagree, its rather good but you have to read how to use it once (a link at top-right corner of text box you write to). And you can use "Preview" button to see results.

[denis-sh]

Looks like my "code duplication from druntime" message foces everybody to not look at code at all (me included). The code uses alloca in a nested function. Fixed in #962.

[denis-sh]

Wrong base branch in #961, superseded by #962.

[denis-sh]

To @AndrejMitrovic:
Your comment #789 (comment)