Fix bug 8900 - Zip with infinite char range fails. #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std.range.Zip` contains a `Tuple`, whose `toString()` function calls `formatElement` which eventually calls this function, leading to a static call to `walkLength` on infinite ranges. Since pul request 880, `walkLength` doesn't work with infinite ranges, so it fails to compile. This change ensures that `walkLength` is called with only valid range types. Bug: http://d.puremagic.com/issues/show_bug.cgi?id=8900
|
Looks good. Just waiting for auto-tester to pass. |
|
Oops (kind of). I removed support for infinite ranges in walklength. I did not see this impact. Well, they do say a compile error is better than a link error, which is definitly better than a run-time error. I hate debugging infinite loops with a passion. Fix looks good to me, though the first check for Well now that it is written, we might as well keep it. LGTM. |
|
What's the matter with FreeBSD_32? |
|
LGTM otherwise |
andralex
added a commit
that referenced
this pull request
Dec 13, 2012
Fix bug 8900 - Zip with infinite char range fails.
|
merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std.range.Zipcontains aTuple, whosetoString()function callsformatElementwhich eventually calls this function when the range element typeisSomeChar, leading to a static call towalkLengthon infinite ranges. Since pull request 880,walkLengthdoesn't work with infinite ranges, so it fails to compile.This change ensures that
walkLengthis called with only valid range types.Bug: http://d.puremagic.com/issues/show_bug.cgi?id=8900