std.socket additions #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strange timeout behavior on Windows (effective timeout = value + ~500ms) has been confirmed on Windows 7, Windows Server 2008 R2 and Windows XP.
I am not particularly fond of the method name, but it follows the existing scheme.
|
@andralex: I updated the pull request to address your comments and added a workaround for pre-XP systems. I'd appreciate if you could look into it soon, as my Thrift work depends on it. |
|
Oh, and as your comments got lost because I overwrote the commits: |
kuettler
pushed a commit
to kuettler/phobos
that referenced
this pull request
Feb 6, 2018
rdmd: Use a lock file to synchronize concurrent builds in the same workDir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a
std.socketrewrite, sorry – this merely exposes the socket options for setting therecv()/send()timeout, and adds a way to get the host name from anInternetAddress. Requires druntime pull request 28.