Skip to content

std.socket additions #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 15, 2011
Merged

std.socket additions #99

merged 4 commits into from
Jun 15, 2011

Conversation

dnadlinger
Copy link
Member

Not a std.socket rewrite, sorry – this merely exposes the socket options for setting the recv()/send() timeout, and adds a way to get the host name from an InternetAddress. Requires druntime pull request 28.

The strange timeout behavior on Windows (effective timeout = value + ~500ms) has been confirmed on Windows 7, Windows Server 2008 R2 and Windows XP.
I am not particularly fond of the method name, but it follows the existing scheme.
@dnadlinger
Copy link
Member Author

@andralex: I updated the pull request to address your comments and added a workaround for pre-XP systems. I'd appreciate if you could look into it soon, as my Thrift work depends on it.

@dnadlinger
Copy link
Member Author

Oh, and as your comments got lost because I overwrote the commits: getOption() doesn't simply return a Duration because it is an overload to three other, already existing methods – I figured it would make sense to stick with the existing API for now, even if it has its issues.

andralex added a commit that referenced this pull request Jun 15, 2011
@andralex andralex merged commit b4a5f33 into dlang:master Jun 15, 2011
kuettler pushed a commit to kuettler/phobos that referenced this pull request Feb 6, 2018
rdmd: Use a lock file to synchronize concurrent builds in the same workDir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants