Fix for 11852 -- RDMD broken on the Github HEAD. #104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by Andrej, mkdirRecurse reports an error (on posix systems) if the directory already exists. I have patched rdmd.d with an additional check to make sure that the directory does not already exist, before calling mkdirRecurse.
|
Another possibility is to fix the mkdirRecurse method in std.file module. That way we could make sure that both posix and non-posix systems have the same behavior in D. |
|
There already is dlang/phobos#1818, and checking exists before doing mkdirRecurse has a rae condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Andrej, mkdirRecurse reports an error (on posix systems)
if the directory already exists. I have patched rdmd.d with an
additional check to make sure that the directory does not already exist,
before calling mkdirRecurse.
I have tested this fix on my Ubuntu box and it works.