Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 11983 - RDMD masks out segmentation faults #111

Closed
wants to merge 1 commit into from

Conversation

WalterBright
Copy link
Member

@CyberShadow
Copy link
Member

So now it masks an identifiable exit code with an unidentifiable one? Hardly an improvement.

The user is expecting rdmd to behave like the shell, which is IMO an invalid issue. But if we are to cater to that, rdmd should at least return the exit code the user expects, and mimic the shell's behavior (which is, again, questionable IMO).

@CyberShadow
Copy link
Member

An actual fix would be to use the system exec call to actually replace the current process with the user's program, on systems which support it (not Windows). Then the signal/exit code/etc. is passed to the shell directly.

@WalterBright
Copy link
Member Author

Suggest some code, please. This is marked as a regression, and so needs a fix shortly. (Though I am not convinced it really is a regression.)

@CyberShadow
Copy link
Member

Fair enough, since it was me who broke it ;)

#112

@WalterBright
Copy link
Member Author

I like your fix better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants