rdmd fixes #14
Merged
rdmd fixes #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes usage of rdmd by multiple users on the same system. Note that a malicious user might still pre-create a directory in /tmp. This might be exploited (e.g. by placing executable or object files with dates way into the future).
|
Ugh, found another bug... Annoyingly this prevents using rdmd with Visual D (which uses a non-standard extension). I'll add the fix to this pull request (edit: when GitHub gets back online properly). |
This is just a hack around the problem that rdmd can't parse DMD options which take an argument separated by a space (such as -map).
rdmd already scans the command line to find the point where option parsing should stop. Including this getopt option breaks using rdmd with e.g. DMD's -map option.
|
Two more problems came up during attempts to integrate rdmd with Visual D. Please review. |
|
All looks good to me. |
WalterBright
added a commit
that referenced
this pull request
Oct 24, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes. See the commit list (and the extended commit messages) for details.