rdmd: Don't recompile the program if only current directory changes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the absolute path to the root .d file instead. It is certainly possible that the build result will depend on the current directory. For example, if the root file imports other modules, these will be sought in the current directory first. However, this is an unlikely use case, and can be simulated using e.g. --force or -I%CD%. On the other hand, having your script be rebuilt every time it is run from a different directory is an unnecessary waste of time and disk space.
|
LGTM, works on Posix. And I agree with the change as well. There's no bugzilla issue though, mind creating one and we'll close it? |
ghost
pushed a commit
that referenced
this pull request
Sep 8, 2014
rdmd: Don't recompile the program if only current directory changes
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the absolute path to the root .d file instead.
It is certainly possible that the build result will depend on
the current directory. For example, if the root file imports
other modules, these will be sought in the current directory
first. However, this is an unlikely use case, and can be
simulated using e.g. --force or -I%CD%.
On the other hand, having your script be rebuilt every time
it is run from a different directory is an unnecessary waste
of time and disk space.