Minimize stat calls #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| yap("stat ", workDir); | ||
| DirEntry workDirEntry; | ||
| const workDirExists = | ||
| collectException(workDirEntry = dirEntry(workDir)) is null; |
There was a problem hiding this comment.
Simpler:
const workDirExists = assertNotThrown(workDirEntry = dirEntry(workDir));There was a problem hiding this comment.
That doesn't seem to do what we need here.
| @@ -205,7 +214,8 @@ int main(string[] args) | |||
| } | |||
|
|
|||
| // Have at it | |||
| if (isNewer(root, exe) || anyNewerThan(myDeps.keys, exe)) | |||
| auto exeTime = exe.timeLastModified(SysTime.min); | |||
| if (chain(root.only, myDeps.byKey).array.anyNewerThan(exeTime)) | |||
There was a problem hiding this comment.
Heheh, .array again. I guess it won't hurt much. anyNewerThan should ideally take a range instead of an array, but let's leave that for some future pull request.
There was a problem hiding this comment.
Yah. This script's running time is dominated by system calls and processes spawned. The equivalent written in a traditional scripting language would do plenty more allocation and would be likely a bit slower anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimize stat calls. Also a few refactorings.