Check for existence of 'objs' directory and create one if it doesn't exist. #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enforce(dryRun || objDirEntry.isDir, | ||
| "Entry `"~objDir~"' exists but is not a directory."); | ||
| } | ||
| else |
There was a problem hiding this comment.
How about the following instead?
if (exists(objDir))
{
enforce(dryRun || isDir(objDir));
}
else
{
mkdirRecurse(objDir);
}
|
I like your suggestion but on the other hand I've tried to be consistent with overall code style of the utility. |
MartinNowak
added a commit
that referenced
this pull request
Jun 2, 2013
Check for existence of 'objs' directory and create one if it doesn't exist.
It's not just about code style. Martin's suggested change results in two filesystem calls instead of one. The original code was better. |
It used exceptions for unexceptional code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that when using with latest ldc2 compiler rdmd did not check for existence of directory for object files. This patch check for such a directory and creates one if it doesn't exist.