Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink OpenMP surface area #20

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Shrink OpenMP surface area #20

merged 1 commit into from
Nov 29, 2023

Conversation

D-Se
Copy link
Owner

@D-Se D-Se commented Nov 29, 2023

  • limit manually setting OpenMP options by the user for simplicity and code maintainability.
  • hardcoded throttle value in ifelse: from 10k observations, 10 threads used, and 1 more thread every 1024, unless the maximum number of threads is reached, as specified in init_ask_threads.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68f331a) 81.73% compared to head (9b3501c) 87.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   81.73%   87.70%   +5.96%     
==========================================
  Files           5        5              
  Lines         208      187      -21     
==========================================
- Hits          170      164       -6     
+ Misses         38       23      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@D-Se D-Se merged commit 77fe330 into main Nov 29, 2023
3 checks passed
@D-Se D-Se deleted the threads branch November 29, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant