Make variable names in deploy script match those in cw-dao-dapp env.local
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeHartnell
approved these changes
Oct 18, 2021
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
Co-authored-by: Jake Hartnell <Jake.Hartnell@gmail.com>
elsehow
commented
Oct 18, 2021
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
this was causing really difficult-to-diagnose issues for me. it turns out that sh is aliased to bash on most systems (but not on mine, where it's actually sh), and the script was using some bash syntax here and there.
JakeHartnell
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ambiguity about which address to place in which .env.local field.
(This issue is related to #50)