Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polars Feather/IPC reader and writer #437

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Polars Feather/IPC reader and writer #437

merged 1 commit into from
Oct 5, 2023

Conversation

somaiyamansi
Copy link
Contributor

@somaiyamansi somaiyamansi commented Oct 4, 2023

This PR adds PolarsFeatherReader and PolarsFeatherWriter classes to read and write Feather/Arrow IPC files using Polars for issue #421

Changes

The following files were updated:

polars_extensions.py: Added the classes to read and write feather files
test_polars_extensions.py: Added a single test case to evaluate the read and write functionality
notebook.ipynb: Added materialization example
my_script.py: Added materialization example
dag.png: New DAG generated after running my_script.py

How I tested this

Ran the unit tests and circleci jobs locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This commit adds PolarsFeatherReader and PolarsFeatherWriter to read and write Feather/Arrow IPC files using Polars.

Additional changes:
- Added a test for the reader and writer classes
- Added to the Polars materialization example
- Added a new dag.png file reflecting the outputs of all materializers thus far

Related issue #421
@somaiyamansi somaiyamansi changed the title Adds Polars Feather/IPC reader and writer Polars Feather/IPC reader and writer Oct 4, 2023
@skrawcz
Copy link
Collaborator

skrawcz commented Oct 4, 2023

@somaiyamansi did you run the example too? just double checking.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@skrawcz skrawcz merged commit 119fe74 into DAGWorks-Inc:main Oct 5, 2023
21 checks passed
@skrawcz
Copy link
Collaborator

skrawcz commented Oct 5, 2023

Thanks @somaiyamansi !

@somaiyamansi somaiyamansi deleted the polars-feather branch October 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants