Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes new viz kwargs through to display_all_functions #525

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Nov 9, 2023

So that we're consistent with the new capabilities.

Changes

  • display_all_functions

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

So that we're consistent with the new capabilities.
Copy link
Contributor

sweep-ai bot commented Nov 9, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@skrawcz skrawcz merged commit d6a8bab into main Nov 11, 2023
22 checks passed
@skrawcz skrawcz deleted the adjust_display_function branch November 11, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant