Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Blocks Order Issue 189 #208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow Blocks Order Issue 189 #208

wants to merge 4 commits into from

Conversation

holbrookb
Copy link
Member

Allow blocks now always in same order as in conf file.

@holbrookb
Allow Blocks Order Issue 189
b2bfff2 
Allow blocks now always in same order as in conf file.
eaescob
eaescob reviewed Apr 5, 2022
View reviewed changes
src/s_conf.c Outdated Show resolved Hide resolved
@holbrookb
Update s_conf.c
cdd01d2 
Remove current allow blocks too.
@eaescob eaescob requested a review from rscs April 5, 2022 22:36
@holbrookb
Update s_conf.c
e86b670 
A little cosmetic change
@eaescob eaescob linked an issue Apr 6, 2022 that may be closed by this pull request
Maintain order of allow{} blocks. #189
Open
crigler
crigler suggested changes May 6, 2022
View reviewed changes
Copy link
Contributor

@crigler crigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like remove_allows makes every struct Client's user->allow field become a dangling pointer to a now-freed entry from the old allows list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crigler crigler crigler requested changes

@eaescob eaescob eaescob approved these changes

@rscs rscs Awaiting requested review from rscs

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Bahamut v2.2.2
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintain order of allow{} blocks.
3 participants
@holbrookb @eaescob @crigler