-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1237 Implement AsyncOp for general polling epoch tasks #1238
Conversation
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
Codecov Report
@@ Coverage Diff @@
## develop #1238 +/- ##
===========================================
+ Coverage 81.01% 81.08% +0.07%
===========================================
Files 730 733 +3
Lines 28057 28145 +88
===========================================
+ Hits 22730 22822 +92
+ Misses 5327 5323 -4
|
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
PR tests (intel 18.03, ubuntu, mpich)
|
PR tests (intel 19, ubuntu, mpich)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good, though there's some refactoring that would be nice for clarity.
a9484df
to
d2d609c
Compare
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
PR tests (intel 18.03, ubuntu, mpich)
|
PR tests (intel 19, ubuntu, mpich)
|
Fixes #1237