1237 Implement AsyncOp for general polling epoch tasks #1238

lifflander · 2021-01-28T02:57:09Z

azure-pipelines · 2021-01-28T04:12:05Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<TestMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=MyCol, MsgT=TestMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<MyCol, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(155): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=MyCol, T=TestMsg, f=colHan, CbkT=vt::pipe::callback::cbunion::CallbackTyped<TestMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(116): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=MyCol, MsgT=TestMsg, f=colHan]" 
/vt/examples/callback/callback.cc(151): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb1DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb1DJacobi, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, T=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb1DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi1d_vt.cc(179): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb2DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb2DJacobi, vt::Index2D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, T=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb2DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi2d_vt.cc(221): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<Hello::ReduceMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=Hello, MsgT=Hello::ReduceMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<Hello, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=Hello, T=Hello::ReduceMsg, f=&Hello::done, CbkT=vt::pipe::callback::cbunion::CallbackTyped<Hello::ReduceMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=Hello, MsgT=Hello::ReduceMsg, f=&Hello::done]" 
/vt/examples/hello_world/hello_world_collection_reduce.cc(64): here

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

codecov · 2021-01-28T04:21:39Z

Codecov Report

Merging #1238 (a9484df) into develop (b9214ca) will increase coverage by 0.07%.
The diff coverage is 91.95%.

@@             Coverage Diff             @@
##           develop    #1238      +/-   ##
===========================================
+ Coverage    81.01%   81.08%   +0.07%     
===========================================
  Files          730      733       +3     
  Lines        28057    28145      +88     
===========================================
+ Hits         22730    22822      +92     
+ Misses        5327     5323       -4

Impacted Files	Coverage Δ
src/vt/messaging/async_op.h	`0.00% <0.00%> (ø)`
src/vt/messaging/async_op.cc	`72.72% <72.72%> (ø)`
src/vt/messaging/async_op_wrapper.h	`86.66% <86.66%> (ø)`
src/vt/messaging/active.cc	`84.56% <100.00%> (+0.26%)`	⬆️
src/vt/messaging/active.h	`74.62% <100.00%> (ø)`
src/vt/messaging/active.impl.h	`98.58% <100.00%> (+0.03%)`	⬆️
tests/unit/active/test_async_op.cc	`100.00% <100.00%> (ø)`
tests/unit/atomic/test_atomic.cc	`98.68% <0.00%> (-1.32%)`	⬇️
src/vt/handler/handler.cc	`100.00% <0.00%> (ø)`
src/vt/sequence/sequencer.cc	`100.00% <0.00%> (ø)`
... and 10 more

azure-pipelines · 2021-01-28T04:25:09Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<TestMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=MyCol, MsgT=TestMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<MyCol, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(155): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=MyCol, T=TestMsg, f=&colHan, CbkT=vt::pipe::callback::cbunion::CallbackTyped<TestMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(116): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=MyCol, MsgT=TestMsg, f=&colHan]" 
/vt/examples/callback/callback.cc(151): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb1DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb1DJacobi, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, T=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb1DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi1d_vt.cc(179): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb2DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb2DJacobi, vt::Index2D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, T=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb2DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi2d_vt.cc(221): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<Hello::ReduceMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=Hello, MsgT=Hello::ReduceMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<Hello, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=Hello, T=Hello::ReduceMsg, f=&Hello::done, CbkT=vt::pipe::callback::cbunion::CallbackTyped<Hello::ReduceMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=Hello, MsgT=Hello::ReduceMsg, f=&Hello::done]" 
/vt/examples/hello_world/hello_world_collection_reduce.cc(64): here

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

azure-pipelines · 2021-01-28T04:33:40Z

PR tests (intel 18.03, ubuntu, mpich)

icc: command line warning #10006: ignoring unknown option '-Wdouble-promotion'
icc: command line warning #10006: ignoring unknown option '-Wcast-align'
icc: command line warning #10006: ignoring unknown option '-Wstrict-overflow=5'
icc: command line warning #10006: ignoring unknown option '-Wpedantic'
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo

azure-pipelines · 2021-01-28T04:51:18Z

PR tests (intel 19, ubuntu, mpich)

icc: command line warning #10148: option '-Wdouble-promotion' not supported
icc: command line warning #10148: option '-Wcast-align' not supported
icc: command line warning #10148: option '-W=strict-overflow=5' not supported
icc: command line warning #10148: option '-Wpedantic' not supported
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo

src/vt/messaging/async_op.h

cz4rs

looks good to me

PhilMiller

This all looks good, though there's some refactoring that would be nice for clarity.

src/vt/messaging/active.cc

src/vt/messaging/active.h

src/vt/messaging/active.impl.h

src/vt/messaging/async_op.cc

… MPI

azure-pipelines · 2021-01-30T20:58:36Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<TestMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=MyCol, MsgT=TestMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<MyCol, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(155): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=MyCol, T=TestMsg, f=&colHan, CbkT=vt::pipe::callback::cbunion::CallbackTyped<TestMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(116): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=MyCol, MsgT=TestMsg, f=&colHan]" 
/vt/examples/callback/callback.cc(151): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb1DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb1DJacobi, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, T=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb1DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi1d_vt.cc(179): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb2DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb2DJacobi, vt::Index2D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, T=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb2DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi2d_vt.cc(221): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<Hello::ReduceMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=Hello, MsgT=Hello::ReduceMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<Hello, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=Hello, T=Hello::ReduceMsg, f=&Hello::done, CbkT=vt::pipe::callback::cbunion::CallbackTyped<Hello::ReduceMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=Hello, MsgT=Hello::ReduceMsg, f=&Hello::done]" 
/vt/examples/hello_world/hello_world_collection_reduce.cc(64): here

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

azure-pipelines · 2021-01-30T21:11:20Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/linear_model.cc(66): warning: integer conversion resulted in a change of sign

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<TestMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=MyCol, MsgT=TestMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<MyCol, TestMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<MyCol, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(155): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=MyCol, T=TestMsg, f=colHan, CbkT=vt::pipe::callback::cbunion::CallbackTyped<TestMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(116): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=MyCol, MsgT=TestMsg, f=colHan]" 
/vt/examples/callback/callback.cc(151): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb1DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb1DJacobi, LinearPb1DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb1DJacobi, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, T=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb1DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb1DJacobi, MsgT=LinearPb1DJacobi::ReduxMsg, f=&LinearPb1DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi1d_vt.cc(179): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<LinearPb2DJacobi::ReduxMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<LinearPb2DJacobi, LinearPb2DJacobi::ReduxMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<LinearPb2DJacobi, vt::Index2D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, T=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB, CbkT=vt::pipe::callback::cbunion::CallbackTyped<LinearPb2DJacobi::ReduxMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=LinearPb2DJacobi, MsgT=LinearPb2DJacobi::ReduxMsg, f=&LinearPb2DJacobi::checkCompleteCB]" 
/vt/examples/collection/jacobi2d_vt.cc(221): here

/vt/src/vt/pipe/callback/proxy_send/callback_proxy_send.h(61): warning: overloaded virtual function "vt::pipe::callback::CallbackBase<SignalT>::trigger_ [with SignalT=vt::pipe::signal::Signal<Hello::ReduceMsg>]" is only partially overridden in class "vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>"
          detected during:
            instantiation of class "vt::pipe::callback::CallbackProxySend<ColT, MsgT> [with ColT=Hello, MsgT=Hello::ReduceMsg]" 
/usr/include/c++/7/bits/unique_ptr.h(821): here
            instantiation of "std::_MakeUniq<_Tp>::__single_object std::make_unique<_Tp,_Args...>(_Args &&...) [with _Tp=vt::pipe::callback::CallbackProxySend<Hello, Hello::ReduceMsg>, _Args=<const vt::HandlerType &, vt::vrt::VirtualElmProxyType<Hello, vt::Index1D> &>]" 
/vt/src/vt/pipe/pipe_manager_tl.impl.h(176): here
            instantiation of "CbkT vt::pipe::PipeManagerTL::makeCallbackSingleProxySend<ColT,T,f,CbkT>(ColT::ProxyType) [with ColT=Hello, T=Hello::ReduceMsg, f=&Hello::done, CbkT=vt::pipe::callback::cbunion::CallbackTyped<Hello::ReduceMsg>]" 
/vt/src/vt/pipe/pipe_manager.impl.h(121): here
            instantiation of "vt::Callback<MsgT> vt::pipe::PipeManager::makeSend<ColT,MsgT,f>(ColT::ProxyType) [with ColT=Hello, MsgT=Hello::ReduceMsg, f=&Hello::done]" 
/vt/examples/hello_world/hello_world_collection_reduce.cc(64): here

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

/vt/src/vt/vrt/collection/balance/model/raw_data.h(81): warning: integer conversion resulted in a change of sign

azure-pipelines · 2021-01-30T21:29:30Z

PR tests (intel 18.03, ubuntu, mpich)

icc: command line warning #10006: ignoring unknown option '-Wdouble-promotion'
icc: command line warning #10006: ignoring unknown option '-Wcast-align'
icc: command line warning #10006: ignoring unknown option '-Wstrict-overflow=5'
icc: command line warning #10006: ignoring unknown option '-Wpedantic'
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo

azure-pipelines · 2021-01-30T21:34:52Z

PR tests (intel 19, ubuntu, mpich)

icc: command line warning #10148: option '-Wdouble-promotion' not supported
icc: command line warning #10148: option '-Wcast-align' not supported
icc: command line warning #10148: option '-W=strict-overflow=5' not supported
icc: command line warning #10148: option '-Wpedantic' not supported
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo

lifflander requested review from PhilMiller, cz4rs, nmm0, JacobDomagala, jstrzebonski and nlslatt January 28, 2021 02:57

lifflander added the CUDA-support label Jan 28, 2021

DARMA-tasking deleted a comment from azure-pipelines bot Jan 28, 2021

cz4rs reviewed Jan 28, 2021

View reviewed changes

src/vt/messaging/async_op.h Outdated Show resolved Hide resolved

cz4rs approved these changes Jan 28, 2021

View reviewed changes

PhilMiller approved these changes Jan 29, 2021

View reviewed changes

lifflander added 13 commits January 30, 2021 12:22

#1237: active: implement general AsyncOp that VT polls

b95b00a

#1237: active: implement CUDA event AsyncOp

98d87d9

#1237: tests: write test for AsyncOp infrastructure with non-blocking…

11edd8f

… MPI

#1237: active: fix indentation

26e448e

#1237: tests: simpify test for AsyncOp

9e6e76b

#1237: active: add default constructor

37d4192

#1237: active: remove invalid constructor for some compilers

c5db57d

#1237: active: fix actual bug in constructor when trace enabled

591355e

#1237: active: only include required header

0d3e684

#1237: active: return directly from testAll

2a4a866

#1237: active: rename IRecvHolder to RequestHolder

6776bec

#1237: active: simplify the logic around swap

c1db2bc

#1237: active: simplify logic in registering AsyncOp

d2d609c

lifflander force-pushed the 1237-polling-epoch-task branch from a9484df to d2d609c Compare January 30, 2021 20:31

lifflander merged commit 4c49014 into develop Jan 31, 2021

cz4rs mentioned this pull request Jun 15, 2021

move vt version number into a separate file #1467

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1237 Implement AsyncOp for general polling epoch tasks #1238

1237 Implement AsyncOp for general polling epoch tasks #1238

lifflander commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

codecov bot commented Jan 28, 2021 •

edited

Loading

azure-pipelines bot commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

cz4rs left a comment

PhilMiller left a comment

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

1237 Implement AsyncOp for general polling epoch tasks #1238

1237 Implement AsyncOp for general polling epoch tasks #1238

Conversation

lifflander commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

codecov bot commented Jan 28, 2021 • edited Loading

Codecov Report

azure-pipelines bot commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

azure-pipelines bot commented Jan 28, 2021

cz4rs left a comment

Choose a reason for hiding this comment

PhilMiller left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

azure-pipelines bot commented Jan 30, 2021

codecov bot commented Jan 28, 2021 •

edited

Loading