Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate input components #4302

Merged
merged 11 commits into from
Jul 30, 2024
Merged

separate input components #4302

merged 11 commits into from
Jul 30, 2024

Conversation

blanchco
Copy link
Contributor

@blanchco blanchco commented Jul 29, 2024

Description

  • separate out number and text inputs from tera-input component
  • tera-input-text formats text as nist onBlur when the input is numbers only
  • tera-input-number formats text as nist whilst user is typing and will always output number type

@blanchco blanchco self-assigned this Jul 29, 2024
@blanchco blanchco marked this pull request as ready for review July 29, 2024 17:12
@blanchco blanchco requested a review from shawnyama July 29, 2024 20:55
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, thanks

@blanchco blanchco merged commit c303eb9 into main Jul 30, 2024
5 checks passed
@blanchco blanchco deleted the separate-tera-input-number branch July 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants