Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collaboration capable workflow - first pass #4336

Merged
merged 17 commits into from
Aug 12, 2024
Merged

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Jul 31, 2024

Summary

Version 0 of workflow collaboration feature. Not we assume that people will not modify the same exact node at the same time.

  • The changes add/augment the Java classes for WorkflowNode and WorkflowEdge, adding in version number and isDeleted tombstone flag. Note currently this is only for API end - the UI side is still using their own types. Consolidation will come later.

  • Add in logic to handle entire-workflow update, this introduces tombstoning logic, meaning that we do not delete nodes/edges, but rather just mark them as deleted.

  • Update UI workflow service to account for tombstoning

Testing

You need two terarium browser sessions, A and B

  • A: create workflow, add model operation, add model-config operation, connect them
  • B: goto the same workflow, verify you can see model => model-config
  • A: add another operation, say simulate, wait for 7-8 seconds for workflow write to occur or check network tab for workflow-POST
  • B: remove the model operation, wait for 7-8 seconds for workflow write to occur or check network tab for workflow-POST
  • A: refresh, verify that we still have simulated operation, verify that model-operation is removed
  • B: refresh, verify that model operation is deleted, plus that there is a new simulate operation

@mwdchang mwdchang changed the title start java types for workflow collaboration capable workflow - first pass Aug 12, 2024
Copy link
Contributor

@jryu01 jryu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mwdchang and others added 2 commits August 12, 2024 15:07
Co-authored-by: Yohann Paris <github@yohannparis.com>
Co-authored-by: Yohann Paris <github@yohannparis.com>
@mwdchang mwdchang merged commit 2086dd0 into main Aug 12, 2024
8 checks passed
@mwdchang mwdchang deleted the workflow-java-classes branch August 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants