-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collaboration capable workflow - first pass #4336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwdchang
changed the title
start java types for workflow
collaboration capable workflow - first pass
Aug 12, 2024
mwdchang
requested review from
dgauldie,
dvince2,
YohannParis,
jryu01,
Tom-Szendrey,
shawnyama,
blanchco and
asylves1
as code owners
August 12, 2024 13:56
YohannParis
approved these changes
Aug 12, 2024
jryu01
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yohann Paris <github@yohannparis.com>
Co-authored-by: Yohann Paris <github@yohannparis.com>
dvince2
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Version 0 of workflow collaboration feature. Not we assume that people will not modify the same exact node at the same time.
The changes add/augment the Java classes for WorkflowNode and WorkflowEdge, adding in version number and isDeleted tombstone flag. Note currently this is only for API end - the UI side is still using their own types. Consolidation will come later.
Add in logic to handle entire-workflow update, this introduces tombstoning logic, meaning that we do not delete nodes/edges, but rather just mark them as deleted.
Update UI workflow service to account for tombstoning
Testing
You need two terarium browser sessions, A and B