-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch refactor #180
Merged
Merged
Patch refactor #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 96.77% 97.78% +1.00%
==========================================
Files 58 64 +6
Lines 3627 4916 +1289
==========================================
+ Hits 3510 4807 +1297
+ Misses 117 109 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
All green and checklist complete. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a HUGE pull request. It refactors many (most) of DASCore's internals. Despite the immensity of the changes, I don't think it introduces any significant backward incompatibilities. Here are a few highlights:
There are also significant speed ups as shown in the following snapshot from the asv benchmarks. Patch, merge, chunk, and select are now significantly faster. Generating string representations for Patches and Spools, however, is not about 60% slower. This is largely due to the addition of rich styling, and probably wont be a burden for most codes since calling
__str__
on a large number of DASCore objects is not likely a common use.Here are a few things left to do:
pass_filter
andtaper
.Patch
to explain string repr. and coordinatesChecklist
I have (if applicable):