Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pydantic < 2 #181

Merged
merged 1 commit into from
Jul 1, 2023
Merged

pin pydantic < 2 #181

merged 1 commit into from
Jul 1, 2023

Conversation

d-chambers
Copy link
Contributor

Description

Pydantic V2 was released yesterday. It has several breaking changes (which break DASCore) so I am pinning the requirement to less than 2 until we update DASCore's pydantic models.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #181 (3a9ca4f) into master (af75507) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #181   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          58       58           
  Lines        3627     3627           
=======================================
  Hits         3510     3510           
  Misses        117      117           
Flag Coverage Δ
unittests 96.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-chambers d-chambers merged commit 26d7961 into master Jul 1, 2023
@d-chambers d-chambers deleted the pin_pydantic branch July 1, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant