Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 #197

Merged
merged 11 commits into from
Jul 21, 2023
Merged

Pydantic v2 #197

merged 11 commits into from
Jul 21, 2023

Conversation

d-chambers
Copy link
Contributor

Description

This PR adds support for pydantic V2. I mainly just got it working, there are other pydanitic optimizations which can be made and always enumerable cleanups.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #197 (566ce00) into master (d9ce036) will decrease coverage by 0.96%.
The diff coverage is 97.46%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   98.63%   97.67%   -0.96%     
==========================================
  Files          74       74              
  Lines        5557     5557              
==========================================
- Hits         5481     5428      -53     
- Misses         76      129      +53     
Flag Coverage Δ
unittests 97.67% <97.46%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dascore/utils/hdf5.py 89.89% <85.71%> (ø)
dascore/utils/models.py 97.22% <91.66%> (-1.06%) ⬇️
dascore/core/coordmanager.py 100.00% <100.00%> (ø)
dascore/core/coords.py 100.00% <100.00%> (ø)
dascore/core/schema.py 94.73% <100.00%> (-5.27%) ⬇️
dascore/io/core.py 100.00% <100.00%> (ø)
dascore/io/indexer.py 96.15% <100.00%> (ø)
dascore/io/pickle/core.py 100.00% <100.00%> (+6.66%) ⬆️
dascore/io/quantx/utils.py 98.64% <100.00%> (ø)
dascore/io/tdms/utils.py 93.00% <100.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

@d-chambers
Copy link
Contributor Author

Looking at the coverage report, I am nearly certain the coverage report is wrong here. I am going to merge for now so I can work on other features that depend on this. Will fix coverage later if this turned out to be correct.

@d-chambers d-chambers merged commit 9134243 into master Jul 21, 2023
@d-chambers d-chambers deleted the pydantic_v2 branch July 21, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant