-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API cleanup #249
API cleanup #249
Conversation
Oops, looks like this branch was based on the wrong branch. it should be fine if we squash and merge though. |
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 99.06% 99.07%
=======================================
Files 79 79
Lines 6444 6462 +18
=======================================
+ Hits 6384 6402 +18
Misses 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@d-chambers Would it be ok to include this and #246 in the 0.0.14 release? I have thoroughly tested the current master branch with different data types and operations, and it's ready for release. |
Description
This PR cleans up a few API issues we discussed yesterday in the sprint:
update_coords
rather thanupdate_attrs
to change attributes in the tutorialiselect
-like methods in favor of asamples
argument. This is consistent withrolling
, etc.tran
namespace, now transformations are just patch methodsOnce #248 is implemented the changes we discussed will be complete.
Checklist
I have (if applicable):