Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks for the DASCore paper #317

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Small tweaks for the DASCore paper #317

merged 5 commits into from
Dec 19, 2023

Conversation

d-chambers
Copy link
Contributor

Description

This PR:

  • Fixes an issue with the colorbar showing up on the wrong plot for a waterfall plot with multiple panels
  • Adds an "example_event_2" which has units set and is filtered for easier viewing.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa256b2) 99.50% compared to head (7cdccd6) 99.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          89       89           
  Lines        7033     7041    +8     
=======================================
+ Hits         6998     7006    +8     
  Misses         35       35           
Flag Coverage Δ
unittests 99.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit d6d7677 into master Dec 19, 2023
15 checks passed
@d-chambers d-chambers deleted the paper_tweaks branch December 19, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant