Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian filter and smoothing recipe #337

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Gaussian filter and smoothing recipe #337

merged 1 commit into from
Jan 5, 2024

Conversation

d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Jan 5, 2024

Description

This PR addresses #296 by implementing a Patch.gaussian_filter method. Patch.savgol_filter was added previously.

Additionally, I created a recipe which demonstrates each of the smoothing methods (rolling, gaussian, savgol). I also tweaked the existing savgol_filter implementation so that multiple dimensions can be filtered in the same function call.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8190ec7) 99.52% compared to head (671b6a1) 99.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files          91       91           
  Lines        7192     7201    +9     
=======================================
+ Hits         7158     7167    +9     
  Misses         34       34           
Flag Coverage Δ
unittests 99.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor Author

I am going to merge this so the new docs build (I need to setup an PR doc deployment, but not today...)

@ariellellouch do you mind taking a look before the next release (probably towards the end of next week) and open a new PR/issue if you can think of any changes to make?

@d-chambers d-chambers merged commit 87de2c5 into master Jan 5, 2024
15 checks passed
@d-chambers d-chambers deleted the smooth_recipe branch January 5, 2024 14:19
@ariellellouch
Copy link
Contributor

Thanks!
It looks good to me, so no need for a new PR
The only comment I have is that the .qmd file (line 112) seems to be cut mid-line

@d-chambers
Copy link
Contributor Author

The only comment I have is that the .qmd file (line 112) seems to be cut mid-line

Thanks! I am not sure how I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants