Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the RSF writer to byteorder Fortran due to RSF requirement #343

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

aaronjgirard
Copy link
Collaborator

Description

The RSF writer was default output to C byteorder, but RSF requires Fortran byte order. This fixes that so Madagascar can read the outputs by default.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@aaronjgirard aaronjgirard added the ready_for_review PR is ready for review label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (623e07e) 99.53% compared to head (01a2a0e) 99.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          91       91           
  Lines        7242     7242           
=======================================
  Hits         7208     7208           
  Misses         34       34           
Flag Coverage Δ
unittests 99.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@d-chambers d-chambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@d-chambers
Copy link
Contributor

Looks good. Did you want to change anything about how the time is stored in RSF files (if I recall correctly, that was the other thing keeping rsf output of DASCore from plotting) ? We can save that for a future PR but it should probably be given some more thought at some point.

@aaronjgirard
Copy link
Collaborator Author

aaronjgirard commented Jan 27, 2024 via email

@d-chambers d-chambers merged commit 2fd62c7 into master Jan 28, 2024
17 checks passed
@d-chambers d-chambers deleted the rsf_byteorder branch January 28, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_for_review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants