Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_353 #354

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix_353 #354

merged 1 commit into from
Mar 18, 2024

Conversation

d-chambers
Copy link
Contributor

Description

Fixes #353.

The problem was the example event 2 has a time coordinate that has a dtype of float rather than datetime64 so the obspy converter needed to be made robust to this.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (1d49530) to head (35fecf1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          91       94    +3     
  Lines        7249     7341   +92     
=======================================
+ Hits         7215     7307   +92     
  Misses         34       34           
Flag Coverage Δ
unittests 99.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit f93ac93 into master Mar 18, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_353 branch March 18, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting example event to obspy fails
1 participant