Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update correlate #364

Closed
wants to merge 3 commits into from
Closed

update correlate #364

wants to merge 3 commits into from

Conversation

ahmadtourei
Copy link
Collaborator

@ahmadtourei ahmadtourei commented Apr 16, 2024

Description

This PR adds four new capabilities to the correlate function:

  • patch can be in the frequency domain, thereby eliminating the need for the Fourier transform step.
  • keeps the patch in the frequency domain after computing the correlation if the idft argument is set to False.
  • an step_size argument to skip receivers.
  • compute correlation over an array of master sources (passed as kwargs) instead of one master source, which results in a 3D patch.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@ahmadtourei ahmadtourei changed the title freq_domain_patch & ifft=False update correlate Apr 16, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.51%. Comparing base (8e93570) to head (c4d5542).

Files Patch % Lines
dascore/proc/correlate.py 96.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   99.53%   99.51%   -0.03%     
==========================================
  Files          97       97              
  Lines        7596     7635      +39     
==========================================
+ Hits         7561     7598      +37     
- Misses         35       37       +2     
Flag Coverage Δ
unittests 99.51% <96.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers mentioned this pull request Jun 12, 2024
5 tasks
@d-chambers
Copy link
Contributor

closed by #400

@d-chambers d-chambers closed this Jun 13, 2024
@d-chambers d-chambers deleted the modif_corr branch June 13, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants