Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix synchronization issue with attrs.dims and coords.dims #367

Merged
merged 2 commits into from
Apr 27, 2024
Merged

fix synchronization issue with attrs.dims and coords.dims #367

merged 2 commits into from
Apr 27, 2024

Conversation

d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Apr 26, 2024 •
edited
Loading

Description

This PR fixes #366.

Side note: some of these internals could really benefit from a re-factoring in the near future.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@d-chambers d-chambers merged commit 38eed62 into master Apr 27, 2024
13 checks passed
@d-chambers d-chambers deleted the fix_attrs_dims_sync branch April 27, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attrs.update(coord=...) doesnt update dims
1 participant
@d-chambers