Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 359 #377

Merged
merged 1 commit into from
May 18, 2024
Merged

fix 359 #377

merged 1 commit into from
May 18, 2024

Conversation

d-chambers
Copy link
Contributor

Description

This PR fixes #359 by adding a pandas.Series dispatch to dascore.utils.time.to_float.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.54%. Comparing base (5aad001) to head (77f60d3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          97       97           
  Lines        7622     7626    +4     
=======================================
+ Hits         7587     7591    +4     
  Misses         35       35           
Flag Coverage Δ
unittests 99.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 8d1af42 into master May 18, 2024
15 checks passed
@d-chambers d-chambers deleted the fix_359 branch May 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_float time util doesnt work with Series
1 participant