Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a simple BoundingBox #40

Merged
merged 24 commits into from
Feb 15, 2022
Merged

Implementation of a simple BoundingBox #40

merged 24 commits into from
Feb 15, 2022

Conversation

PyMarc2
Copy link
Contributor

@PyMarc2 PyMarc2 commented Feb 14, 2022

A BoundingBox is necessary to rapidly know the 3d extent of a structure, wheter it is a polygon, a solid or a scene.

The BoundingBox is analogous to the cuboid, it has x, y and z values.
It cannot interpret or nuance for any curve-like object, thus cannot be directly used to know if an object contains another.

The BoundingBox will be used for raytracing/intersections calculations and for the object-search algorithms

@PyMarc2 PyMarc2 self-assigned this Feb 14, 2022
@PyMarc2 PyMarc2 requested a review from JLBegin February 14, 2022 16:44
Copy link
Contributor

@JLBegin JLBegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes, but I would like an update on the bounding box property tests as discussed before merging.

@PyMarc2
Copy link
Contributor Author

PyMarc2 commented Feb 15, 2022

waiting for confirmation

@PyMarc2 PyMarc2 merged commit 85aa07d into scene-dev Feb 15, 2022
@PyMarc2 PyMarc2 deleted the bbox branch February 15, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants