Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidGroupMerge objects to fix .obj imports #65

Merged
merged 14 commits into from
May 10, 2022
Merged

Conversation

PyMarc2
Copy link
Contributor

@PyMarc2 PyMarc2 commented May 6, 2022

  • SolidGroupMerge is a Solid that takes multiple Solid as an argument and merges them in the same solid. It keeps the information about the solids by correctly managing the labels.
  • SolidModel is a SolidGroupMerge but takes a filepath as an argument.
  • added am example with the droid file correctly labelled.
  • modified SurfaceCollection so it allows to add the same surfaceLabel, but increments it.
  • allow solid.rotate(rotationCenter=Vector(x, y, z)) so we can rotate from another point then the center. Had to implement it when SolidGroupMerge had different objects in it, but it can be useful + it is tested, so I say we keep it.

@PyMarc2 PyMarc2 self-assigned this May 6, 2022
@PyMarc2 PyMarc2 requested a review from JLBegin May 6, 2022 16:19
@PyMarc2 PyMarc2 added the bug Something isn't working label May 6, 2022
@PyMarc2 PyMarc2 marked this pull request as ready for review May 6, 2022 17:23
@JLBegin JLBegin self-requested a review May 10, 2022 17:15
Copy link
Contributor

@JLBegin JLBegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title and description outdated since #71

@PyMarc2 PyMarc2 merged commit 6beb38d into scene-dev May 10, 2022
@PyMarc2 PyMarc2 deleted the fix-obj-import branch May 10, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants