Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle supplement parallel in XSLT #120

Closed
andreabernini opened this issue Mar 20, 2015 · 19 comments
Closed

handle supplement parallel in XSLT #120

andreabernini opened this issue Mar 20, 2015 · 19 comments

Comments

@andreabernini
Copy link

See for instance TM 112362 (P.Oxy. 71.4807)

https://github.com/DCLP/idp.data/blob/dclp/DCLP/113/112362.xml#l107
https://github.com/DCLP/idp.data/blob/dclp/DCLP/113/112362.xml#l108

@HolgerEssler
Copy link

HolgerEssler commented Mar 20, 2015

I suppose the current convention would be:
Leiden+: [αβγ]
xml: <supplied reason="undefined" evidence="parallel">αβγ</supplied>

Cf. however my request in your LitPapText spreadsheet, line 62.

@paregorios
Copy link
Member

by "low corner brackets" do you mean http://www.fileformat.info/info/unicode/char/23a3/index.htm and http://www.fileformat.info/info/unicode/char/23a6/index.htm as oppposed to "[" and "]"?

@rla2118
Copy link

rla2118 commented Mar 25, 2015

Yes, Tom, that looks right.

@paregorios
Copy link
Member

And what is the semantic significance a-la Leiden of such brackets?

@HolgerEssler
Copy link

HolgerEssler commented Mar 25, 2015

I resend my original comment as it was not displayed as I intended it:

I suppose the current convention would be:
Leiden+: [αβγ]
xml: <supplied reason="undefined" evidence="parallel">αβγ</supplied>

Cf. however my request in your LitPapText spreadsheet, line 62.
https://docs.google.com/spreadsheets/d/1F6_Du8DIjixRD4mnvfpbkcn3E0H2_SfBIztCO6Vl6gQ/edit#gid=1879498412

And what is the semantic significance a-la Leiden of such brackets?


Reply to this email directly or view it on GitHub
#120 (comment).

Dr. Holger Essler, AR
Institut für Klassische Philologie I
Residenzplatz 2 (Südflügel)
D-97070 Würzburg

Tel.: +49-931-31-85632
email: Holger.Essler@uni-wuerzburg.de
Institutsseite: www.klassphil.uni-wuerzburg.de
Epikurzentrum: www.epikur-wuerzburg.de

@paregorios
Copy link
Member

So, @HolgerEssler the task for the technical team then is to modify the XSLT stylesheets to insert the relevant Unicode characters, yes?

@HolgerEssler
Copy link

HolgerEssler commented Mar 25, 2015 via email

@HolgerEssler
Copy link

Probably the Text Leiden+ Documentation at
http://papyri.info/editor/documentation?docotype=text should also be
updated:
The entry under "supplied parallel lost" (without specific content)
could be merged with/replaced by the entry under "supplied parallel"
(with example http://papyri.info/ddbdp/p.berl.leihg;2;39).

@paregorios
Copy link
Member

See #134 for a separate ticket about updating Leiden+ documentation.

@paregorios
Copy link
Member

paregorios commented Apr 30, 2015

Reformulating the remaining technical task here:

For XML like <supplied evidence="parallel">...</supplied> the behavior of the XSL should be modified/extended to:

Caveats:

  • whatever the value of the reason attribute, or even in its absence, this convention should be observed
  • do not change any handling for collections other than DCLP

Example files for testing:

@paregorios paregorios changed the title How to render low corner brackets? handle supplement parallel in XSLT Apr 30, 2015
@paregorios
Copy link
Member

@paregorios
Copy link
Member

@HolgerEssler and @andreabernini please review my summation of the tasks as indicated above. If you concur, we will move forward to implement.

@paregorios paregorios self-assigned this Apr 30, 2015
@paregorios
Copy link
Member

blocker for #134

@paregorios
Copy link
Member

Have verified that DDB does not want to see this change affect their collection, so note again my caveat above: this behavior change should be for DCLP texts only.

@HolgerEssler
Copy link

HolgerEssler commented May 2, 2015 via email

@paregorios
Copy link
Member

I did some related work on this in the EpiDoc stylesheets on Friday. Will continue to work on rolling through the relevant changes to us and adding our DCLP-related logic this week.

@paregorios paregorios modified the milestone: backlog May 15, 2015
@paregorios paregorios removed their assignment May 19, 2015
@paregorios paregorios modified the milestone: backlog Feb 12, 2016
@jcowey jcowey added this to the November 2016 milestone Nov 10, 2016
@jcowey jcowey modified the milestones: December 2016, November 2016 Dec 14, 2016
@jcowey jcowey modified the milestones: February 2017, December 2016 Jan 12, 2017
@paregorios paregorios self-assigned this Feb 10, 2017
@paregorios
Copy link
Member

@leoba would you please put this ticket at the top of your list for xslt things to look at next? The issue is clearly laid out in this comment above. Contra my 2015 self's additional comments, I cannot find any code changes I made relevant to this issue.

This one will, I think, require intervention in the EpiDoc stylesheets, rather than the navigator ones. Here's what I think will be required:

  • Add a new template to teisupplied.xsl in order to catch <supplied evidence="parallel"> only when the collection is "dclp". It should then call the named template "supplied-parallel". All of the templates in the file right now first match on the reason attribute and are agnostic as to collection.
  • Add code to the named template "supplied-parallel", which is in htm-teisupplied.xsl, in order to emit the desired brackets when the collection is "dclp". For other collection values, behavior should remain unchanged.

@paregorios paregorios assigned leoba and unassigned paregorios Feb 10, 2017
@leoba
Copy link
Contributor

leoba commented Feb 14, 2017

Done as requested and committed to Sourceforge. Edited to add that I check the new code against bgu.13.2216.xml and it had no effect.

@paregorios paregorios assigned paregorios and unassigned leoba Feb 15, 2017
@paregorios
Copy link
Member

Code commit on EpiDoc sourceforge SVN was https://sourceforge.net/p/epidoc/code/2495/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants