Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add function to create index column #111

Closed
wants to merge 2 commits into from

Conversation

maxwell8888
Copy link
Contributor

uses year_sector_data column
needs to be generalised to take argument to define which columns values
to use to index

uses year_sector_data column
needs to be generalised to take argument to define which columns values
to use to index
@maxwell8888
Copy link
Contributor Author

closes #99. I think Matt G is working on #47 so will wait for that to be finished until I strip the indexing code out of the figure functions - so that it is easy to check the functions can still produce the same output.

@codecov-io
Copy link

Codecov Report

Merging #111 into master will decrease coverage by 1.89%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #111     +/-   ##
=========================================
- Coverage   85.28%   83.39%   -1.9%     
=========================================
  Files          18       19      +1     
  Lines         571      584     +13     
=========================================
  Hits          487      487             
- Misses         84       97     +13
Impacted Files Coverage Δ
R/add_index.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc2ed1...9c7232a. Read the comment docs.

@maxwell8888
Copy link
Contributor Author

I am going to remove usemethod stuff from this because it will end up being more of a utility function so don't want it as a method

@maxwell8888 maxwell8888 changed the title add function to create index column [WIP] add function to create index column Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants