Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 홈 화면 배너 구현 방식 변경 #42

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

coggiee
Copy link
Contributor

@coggiee coggiee commented Jun 4, 2024

연관된 이슈

ex) #이슈번호

issue #41

✅ 작업 내용

이번 PR에서 작업한 내용을 간략히 설명 해주세요(이미지 첨부 가능)

  • 기존 embla로 구현한 캐러셀을 shadcn의 Carousel로 변경

🚦 특이 사항

주의깊게 봐야하는 PR 포인트 & 말하고 싶은 점

  • shadcn의 Carousel은 embla 기반으로 구현되어 있습니다.
    • 내 예매 티켓 구현 방식과 통일성을 가져가고 구현 방식을 단순화하기 위해 변경했습니다.

💬 리뷰 요구사항(선택)


🚨 이슈를 닫아주세요!

ex) close #이슈번호

close #41

@coggiee coggiee added the ⚡️ refactor 기능 추가에 해당하지 않는 코드 리팩토링 label Jun 4, 2024
@coggiee coggiee requested a review from SonSuBin129 June 4, 2024 02:09
@coggiee coggiee self-assigned this Jun 4, 2024
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uket-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 2:09am

Copy link
Contributor

@SonSuBin129 SonSuBin129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 수고하셨습니다 :)

@coggiee coggiee merged commit 3e01b5c into dev Jun 4, 2024
2 checks passed
@coggiee coggiee deleted the refactor/#41 branch June 4, 2024 05:23
SonSuBin129 added a commit to SonSuBin129/uket-FE that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡️ refactor 기능 추가에 해당하지 않는 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor] 홈 화면 배너 구현 방식 변경
2 participants